Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added feedback #2624

Merged
merged 2 commits into from
Oct 9, 2024
Merged

Added feedback #2624

merged 2 commits into from
Oct 9, 2024

Conversation

TobbeCarlsson
Copy link
Contributor

Completion of feedback:

tocarls and lindefors have now given our feedback which can be seen here: #2496

@dd2482-bot
Copy link
Collaborator

Readme is not correctly formatted
Need exactly: ['Assignment Proposal', 'Title', 'Names and KTH ID', 'Deadline', 'Category', 'Description']

Got: ['Assignment Proposal', 'Title', 'Names and KTH ID', 'Deadline', 'Category', 'Description', 'Completion:']

@javierron
Copy link
Collaborator

@TobbeCarlsson Thanks for the submission

@javierron javierron self-assigned this Oct 9, 2024
@javierron javierron added final_submission The final submission of a task feedback labels Oct 9, 2024
@javierron javierron merged commit be38692 into KTH:2024 Oct 9, 2024
1 check passed
@TobbeCarlsson
Copy link
Contributor Author

Does this mean we passed? I can't see grade reported in canvas

@TobbeCarlsson
Copy link
Contributor Author

@javierron

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feedback final_submission The final submission of a task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants